feat(nextjs): Add telemetry collection to NextJS wizard #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thought: We can bump the SDK and test the new span APIs. Will open a separate PR for this. Udate: #459 |
AbhiPrasad
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds telemetry data collection to the NextJS wizard. Specifically:
This PR is unfortunately a little messy because I decided to pull a lot of the
traceStepcalls into the helper functions rather than wrapping the individual calls to the helpers. IMO this is better as we can reuse already existing manual instrumentation when we use these helpers. Also, if telemetry is disabled or the helper is used in a wizard that doesn't support telemetry, thetraceStepwrapper will no-op anyway.closes #450